Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter dropdown for categorization keywords #2097

Merged
merged 10 commits into from
Sep 11, 2023
Merged

Conversation

CollinBeczak
Copy link
Collaborator

Similar to the Keywords filter dropdown in the find challenges page, a new dropdown is created to find challenges with matching categorization keywords. A key difference is that the user can manually change what values are stored in the dropdown.

@CollinBeczak CollinBeczak marked this pull request as draft September 8, 2023 16:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #2097 (a63fcc3) into develop (67a08ef) will decrease coverage by 0.15%.
Report is 16 commits behind head on develop.
The diff coverage is 20.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #2097      +/-   ##
===========================================
- Coverage    24.96%   24.82%   -0.15%     
===========================================
  Files          638      643       +5     
  Lines        21587    22827    +1240     
  Branches      6567     7168     +601     
===========================================
+ Hits          5389     5666     +277     
- Misses       13574    14293     +719     
- Partials      2624     2868     +244     
Files Changed Coverage Δ
...ane/ChallengeFilterSubnav/ChallengeFilterSubnav.js 66.66% <ø> (ø)
...s/WithFilteredChallenges/WithFilteredChallenges.js 30.76% <ø> (ø)
src/components/HOCs/WithSearch/WithSearch.js 57.14% <0.00%> (-1.11%) ⬇️
...rc/components/MobileFilterMenu/MobileFilterMenu.js 0.00% <ø> (ø)
...izationKeywords/ChallengeCategorizationKeywords.js 14.28% <14.28%> (ø)
...engeFilterSubnav/FilterByCategorizationKeywords.js 21.05% <21.05%> (ø)
...components/HOCs/WithSearchRoute/WithSearchRoute.js 49.45% <25.00%> (-1.13%) ⬇️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CollinBeczak CollinBeczak marked this pull request as ready for review September 11, 2023 18:29
@AndrewPhilbin AndrewPhilbin merged commit 5d9bb8b into develop Sep 11, 2023
2 checks passed
@jschwarz2030 jschwarz2030 deleted the filterByKeywords branch October 18, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants