Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bazel_dep for libuv #3114

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Use bazel_dep for libuv #3114

merged 1 commit into from
Jan 4, 2025

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Jan 4, 2025

Use bazel_dep instead of relying on Homebrew installed libuv.

bazel run //platform/glfw:glfw_app --//:renderer=metal -- --style https://raw.githubusercontent.com/maplibre/demotiles/gh-pages/style.json

cc @bdon

@louwers louwers added the build Related to build, configuration or CI/CD label Jan 4, 2025
@louwers louwers requested a review from HarelM January 4, 2025 17:42
@louwers louwers enabled auto-merge (squash) January 4, 2025 17:42
@louwers louwers added the macOS label Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3114-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.6Mi  +433% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3114-compared-to-legacy.txt

Copy link

github-actions bot commented Jan 4, 2025

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0138         +0.0135             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3114-compared-to-main.txt

Copy link

github-actions bot commented Jan 4, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3114-compared-to-main.txt

@louwers louwers merged commit 660f78c into maplibre:main Jan 4, 2025
43 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build, configuration or CI/CD macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants