Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix instrumentation tests #3012

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Attempt to fix instrumentation tests #3012

merged 1 commit into from
Nov 12, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Nov 12, 2024

Try to fix instrumentation tests after #2991.

@louwers louwers added the github_actions Pull requests that update GitHub Actions code label Nov 12, 2024
@louwers louwers requested a review from HarelM November 12, 2024 20:55
@louwers louwers enabled auto-merge (squash) November 12, 2024 20:55
HarelM
HarelM approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it work?

@louwers
Copy link
Collaborator Author

louwers commented Nov 12, 2024

@HarelM I can only tell after merging, as the device test workflow uses what is in main for security reasons.

@louwers louwers merged commit dd7461f into maplibre:main Nov 12, 2024
35 of 36 checks passed
@github-actions GitHub Actions
Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3012-compared-to-main.txt

@louwers louwers mentioned this pull request Nov 13, 2024
Merged
@louwers louwers deleted the fix-instrumentation-tests branch November 13, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgalvan cgalvan cgalvan approved these changes

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louwers @HarelM @cgalvan