Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line SDF shader fix #3010

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Line SDF shader fix #3010

merged 6 commits into from
Nov 13, 2024

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented Nov 12, 2024

Fixes #2130.

@alexcristici alexcristici self-assigned this Nov 12, 2024
@alexcristici alexcristici linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 12, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3010-compared-to-main.txt

@alexcristici alexcristici marked this pull request as ready for review November 12, 2024 22:15
Copy link

github-actions bot commented Nov 12, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3010-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.5Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3010-compared-to-legacy.txt

Copy link

github-actions bot commented Nov 12, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0015         -0.0013             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3010-compared-to-main.txt

@louwers louwers merged commit 0bac36d into maplibre:main Nov 13, 2024
41 of 42 checks passed
@louwers louwers added bug Something isn't working metal Vulkan labels Nov 14, 2024
@alexcristici alexcristici deleted the line-sdf-shader-fix branch November 19, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metal Vulkan
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[iOS - Metal - v6.1.0] - lineDashPattern with steps disappears
4 participants