More context #2537
Merged
More context #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSylvester
force-pushed
the
more-context
branch
from
2d45ca8 to
8fb459a
Compare
artakka
approved these changes
Jun 24, 2024
TimSylvester
merged commit 70b711b
into
maplibre:android-10.3.2-pre
13 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the file and line number of the original call through
SymbolInstanceaccessor methods in addition to explicit checks, since the observed failures are from those calls.Add more explicit checks, particularly before and after the buckets are transferred from the worker threads to the render thread, and avoid using the results when checks fail in hopes of preventing crashes.
Avoid short-circuiting on checks so that if multiple guard values are modified they will all be listed, in order to provide a better sense of the extent of the unexpected changes.