Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A special release for a particular user experiencing rare crashes in the field only. Call stacks indicate several crashes that seem like they must be caused by members from the pointer portion of
key
toplacedVerticalIconIndex
becoming unexpectedly invalid.We insert fixed values between each member and check them on each access in hopes of narrowing down the range of potential places from which this could be caused and skip further processing of the symbol instance once any invalid value has been detected.
Also includes the benchmarking activity from #1850 to confirm that there's no major effect on performance.
The option to log events on a separate thread is extended to be a per-severity option, with the default changed to log errors synchronously but use threads for lower-severity events. This should make it more likely that relevant log events are written in the event of a crash.
clang-format
modifies almost the entire contents of every file, so I'll apply that after people have had a chance to look at the differences.