Android Instrumentation Tests Improvements #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwers
changed the title
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2321-compared-to-main.txt |
cgalvan
approved these changes
Apr 29, 2024
...LibreAndroidTestApp/src/androidTest/java/org/maplibre/android/offline/OfflineDownloadTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to make the Android Instrumentation Tests pass on CI so we can rely on them for PRs.
In this PR I am pulling the logs from AWS Device Farm and log them on GitHub (for debugging in case a test fails).
Had to ignore quite a few tests because they are flaky.
Style.getPredefinedStyle("Streets")was failing unpredictably because the MapTiler styles weren't loaded yet. I replaced it withStyle.getDefaultStyles()[0].urlwherever possible. Maybe I will define the styles needed for the tests near the tests instead of relying on the pre-defined styles in the core (that we want to get rid of at some point).I'll try to improve things further in another PR.