Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-format (pre-commit) #2312

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Apr 23, 2024

No description provided.

@louwers louwers requested a review from cgalvan April 23, 2024 11:37
@louwers louwers changed the title Update pre-commit Update clang-format (pre-commit) Apr 23, 2024
@louwers louwers enabled auto-merge (squash) April 23, 2024 11:37
@louwers
Copy link
Collaborator Author

louwers commented Apr 23, 2024

Reported issue here: pre-commit-ci/issues#210

Copy link

github-actions bot commented Apr 23, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2312-compared-to-main.txt

Copy link

github-actions bot commented Apr 23, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2312-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +20% +23.3Mi  +406% +24.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2312-compared-to-legacy.txt

Copy link

github-actions bot commented Apr 23, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0021         -0.0024             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2312-compared-to-main.txt

@louwers louwers closed this Apr 23, 2024
auto-merge was automatically disabled April 23, 2024 14:06

Pull request was closed

@louwers louwers reopened this Apr 23, 2024
@louwers louwers closed this Apr 23, 2024
@louwers louwers reopened this Apr 23, 2024
@louwers louwers requested review from HarelM and mwilsnd April 23, 2024 22:52
@louwers louwers self-assigned this Apr 23, 2024
@louwers louwers enabled auto-merge (squash) April 23, 2024 22:52
@louwers louwers merged commit 54a07f4 into maplibre:main Apr 24, 2024
33 of 34 checks passed
@louwers louwers deleted the update-pre-commit branch April 24, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants