Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Improvements #2311

Merged
merged 10 commits into from
Apr 23, 2024
Merged

Gradle Improvements #2311

merged 10 commits into from
Apr 23, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Apr 22, 2024

  • Set compileSdk, minSdkVersion and targetSdkVersion inline, this way the IDE can give a hint when they are outdated.
  • Remove compileSdkVersion and buildToolsVersion (deprecated).
  • Small fix to Android device workflow to always try uploading benchmark results.
  • Bump dependencies.

@louwers louwers requested review from artakka and cgalvan April 22, 2024 21:17
@louwers louwers self-assigned this Apr 22, 2024
Copy link

github-actions bot commented Apr 22, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2311-compared-to-main.txt

@louwers
Copy link
Collaborator Author

louwers commented Apr 22, 2024

!benchmark android

Copy link

github-actions bot commented Apr 22, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2311-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +20% +23.3Mi  +406% +24.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2311-compared-to-legacy.txt

Copy link

github-actions bot commented Apr 22, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0015         -0.0017             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2311-compared-to-main.txt

@louwers louwers merged commit b4dcdb1 into maplibre:main Apr 23, 2024
32 of 34 checks passed
@louwers louwers deleted the android-gradle branch April 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants