Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal render tests ignore #1900

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented Nov 28, 2023

Ignored the 4 failing render tests on Metal:
Screenshot 2023-11-28 at 21 51 19

We should re-enable those 4 failing render tests when they will be fixed: #1899

Also ignoreProbing is now enabled to ignore the probe tests.
Maybe we should consider to re-baseline probes at some point.

@alexcristici alexcristici self-assigned this Nov 28, 2023
Copy link

github-actions bot commented Nov 28, 2023

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1900-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +18% +21.4Mi  +399% +23.9Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1900-compared-to-legacy.txt

@alexcristici alexcristici marked this pull request as ready for review November 29, 2023 16:33
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking forward to flip the switch.

@alexcristici alexcristici merged commit abd0be7 into maplibre:main Nov 29, 2023
29 checks passed
@alexcristici alexcristici deleted the metal-render-tests-ignore branch November 29, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Re-enable ignored metal render tests
2 participants