-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared attributes #1898
Shared attributes #1898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1898 +/- ##
==========================================
- Coverage 85.74% 85.73% -0.02%
==========================================
Files 568 568
Lines 28026 28027 +1
==========================================
- Hits 24031 24028 -3
- Misses 3995 3999 +4 ☔ View full report in Codecov by Sentry. |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1898-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1898-compared-to-legacy.txt |
This reverts commit fa9712c.
I've been testing it this morning and all looks good to me. That size reduction alone is worth it. |
Vertex attribute arrays are managed using
shared_ptr
.Eliminates the means to copy assign or construct them entirely for code size.