Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared attributes #1898

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Shared attributes #1898

merged 7 commits into from
Nov 29, 2023

Conversation

TimSylvester
Copy link
Collaborator

Vertex attribute arrays are managed using shared_ptr.
Eliminates the means to copy assign or construct them entirely for code size.

@TimSylvester TimSylvester added the enhancement New feature or request label Nov 28, 2023
@TimSylvester TimSylvester self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5911f01) 85.74% compared to head (06252ee) 85.73%.
Report is 1 commits behind head on main.

❗ Current head 06252ee differs from pull request most recent head 3033880. Consider uploading reports for the commit 3033880 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
- Coverage   85.74%   85.73%   -0.02%     
==========================================
  Files         568      568              
  Lines       28026    28027       +1     
==========================================
- Hits        24031    24028       -3     
- Misses       3995     3999       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 28, 2023

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.6%  -800Ki  -0.7%  -219Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1898-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +18% +21.4Mi  +399% +23.9Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1898-compared-to-legacy.txt

@TimSylvester TimSylvester enabled auto-merge (squash) November 29, 2023 00:24
@TimSylvester TimSylvester merged commit fa9712c into main Nov 29, 2023
29 checks passed
@TimSylvester TimSylvester deleted the shared-attributes branch November 29, 2023 02:57
TimSylvester added a commit that referenced this pull request Nov 29, 2023
@TimSylvester
Copy link
Collaborator Author

Hm, I didn't realize auto-merge would trigger without more approvals. @louwers @mwilsnd should I create a revert PR?

@mwilsnd
Copy link
Collaborator

mwilsnd commented Nov 29, 2023

I've been testing it this morning and all looks good to me. That size reduction alone is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants