Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render tests removed from platform all and moved to integration render tests folder #1895

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Render tests removed from platform all and moved to integration render tests folder #1895

merged 2 commits into from
Nov 28, 2023

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented Nov 28, 2023 •
edited
Loading

We don't need the platform-all folder anymore, it was used before when the render tests were grabbed from web repository. For now I just moved the expected images from platform-all to the integration render tests folder.

@alexcristici alexcristici changed the title Render tests removed from platform all and moved to integration rende… Render tests removed from platform all and moved to integration render tests folder Nov 28, 2023
@alexcristici alexcristici self-assigned this Nov 28, 2023
@alexcristici alexcristici marked this pull request as ready for review November 28, 2023 07:49
@github-actions GitHub Actions
Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1895-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +19% +22.1Mi  +403% +24.1Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1895-compared-to-legacy.txt

@alexcristici alexcristici merged commit f6fb2d9 into maplibre:main Nov 28, 2023
29 checks passed
@alexcristici alexcristici deleted the render-tests-removed-from-platform-all branch November 28, 2023 20:29
louwers pushed a commit to louwers/maplibre-native that referenced this pull request Nov 30, 2023
@alexcristici @louwers
Render tests removed from platform all and moved to integration rende…
809039f 
…r tests folder (maplibre#1895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefankarschti stefankarschti stefankarschti approved these changes

@louwers louwers louwers approved these changes

@cgalvan cgalvan Awaiting requested review from cgalvan

@mwilsnd mwilsnd Awaiting requested review from mwilsnd

@TimSylvester TimSylvester Awaiting requested review from TimSylvester

@sjg-wdw sjg-wdw Awaiting requested review from sjg-wdw

Assignees

@alexcristici alexcristici

Labels
None yet
Projects
MapLibre Native Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcristici @louwers @stefankarschti