Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations #1748

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Optimizations #1748

merged 5 commits into from
Oct 11, 2023

Conversation

TimSylvester
Copy link
Collaborator

Optimizations to deal with the heaviest traces for several metrics observed on the benchmark app in Metal configuration

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d63f94f) 85.70% compared to head (b62ffa6) 85.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1748   +/-   ##
=======================================
  Coverage   85.70%   85.71%           
=======================================
  Files         564      564           
  Lines       27760    27768    +8     
=======================================
+ Hits        23792    23800    +8     
  Misses       3968     3968           
Files Coverage Δ
src/mbgl/geometry/feature_index.cpp 80.00% <100.00%> (ø)
src/mbgl/geometry/feature_index.hpp 100.00% <100.00%> (ø)
src/mbgl/renderer/paint_parameters.cpp 82.35% <ø> (ø)
src/mbgl/tile/geometry_tile_worker.cpp 85.12% <100.00%> (+0.54%) ⬆️
src/mbgl/util/grid_index.hpp 92.34% <95.65%> (-0.35%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louwers louwers enabled auto-merge (squash) October 10, 2023 20:24
@github-actions
Copy link

Size test result

Old size: 8660672 bytes
New size: 8660672 bytes
Difference: +0.00%

@louwers louwers merged commit ce0096a into main Oct 11, 2023
@louwers louwers deleted the ts/metal-opt branch October 11, 2023 01:34
louwers pushed a commit to louwers/maplibre-native that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants