Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum CMake version to 3.19 #1744

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Update minimum CMake version to 3.19 #1744

merged 1 commit into from
Oct 10, 2023

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Oct 9, 2023

Manual cherry-pick of #1643 into the OpenGL 2 branch.

@ntadej ntadej added the cherry-pick This MR was cherry-picked label Oct 9, 2023
@ntadej
Copy link
Collaborator Author

ntadej commented Oct 9, 2023

Hmm, @louwers, any idea why it fails here? I guess it runs one the same runner as main?

@louwers
Copy link
Collaborator

louwers commented Oct 9, 2023

Because old workflows are running apt-get install cmake. 😮‍💨

@louwers
Copy link
Collaborator

louwers commented Oct 9, 2023

OK I prevented it from ever being installed with apt-get 👍

@ntadej
Copy link
Collaborator Author

ntadej commented Oct 9, 2023

Still failing on update ...

@ntadej ntadej merged commit 63992ff into maplibre:opengl-2 Oct 10, 2023
13 of 14 checks passed
@ntadej ntadej deleted the cmake branch October 10, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louwers louwers louwers approved these changes

Assignees
No one assigned
Labels
cherry-pick This MR was cherry-picked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntadej @louwers