-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android annotations: implement Circle
, Line
, Fill
#1724
Merged
louwers
merged 10 commits into
maplibre:android-annotations
from
fynngodau:android-annotations-new-classes
Oct 13, 2023
Merged
Android annotations: implement Circle
, Line
, Fill
#1724
louwers
merged 10 commits into
maplibre:android-annotations
from
fynngodau:android-annotations-new-classes
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a bug in Fill class where geometry updates are not applied.
Had not existed in annotations plugin previously.
louwers
reviewed
Oct 9, 2023
...oid/MapboxGLAndroidSDK/src/main/java/org/maplibre/android/annotations/AnnotationContainer.kt
Show resolved
Hide resolved
louwers
reviewed
Oct 9, 2023
platform/android/MapboxGLAndroidSDK/src/main/java/org/maplibre/android/maps/MapLibreMap.java
Show resolved
Hide resolved
louwers
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artakka can likely have a look at the end of the week.
@fynngodau let me know if you want to merge it earlier. I left two small comments. Overall looks good to me. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android annotations API proposal implementation PR as a part of #1491. Closes #1635.
Circle
,Line
andFill
classes are now usable.CircleManager
,LineManager
andFillManager
have been updated, and pass.Annotation
→KAnnotation
AnnotationContainer
→KAnnotationContainer
Symbol
no longer has the temporary nameKSymbol
.Symbol
class #1637 are removed or no longer commented out. The exception isDraggableAnnotationControllerTest
, which will be re-added in Android Annotations: add click and drag listeners #1634.