Metal macOS render tests updated (#2889)

maplibre · Oct 7, 2024 · ec26136 · ec26136
1 parent 2972708
commit ec26136
Show file tree

Hide file tree

Showing 17 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml
@@ -265,15 +265,13 @@ jobs:
           cmake --build build
 
       - name: Run render tests on macOS
+        id: render_tests
         if: runner.os == 'macOS'
-        # A few are failing
-        # https://github.com/maplibre/maplibre-native/issues/2741
-        # Almost all are failing on Intel GitHub runners (but only on CI)
-        continue-on-error: true
+        continue-on-error: ${{ runner.arch == 'X64' }}
         run: ./build/mbgl-render-test-runner --manifestPath metrics/macos-xcode11-release-style.json
 
       - name: Upload render test artifacts (MacOS)
-        if: runner.os == 'MacOS'
+        if: runner.os == 'MacOS' && steps.render_tests.outcome == 'failure'
         uses: actions/upload-artifact@v4
         with:
           name: render-query-test-results_${{ runner.os }}_${{ matrix.arch }}

diff --git a/...os/render-tests/combinations/heatmap-translucent--fill-translucent/expected.png b/...os/render-tests/combinations/heatmap-translucent--fill-translucent/expected.png
diff --git a/...macos/render-tests/combinations/hillshade-translucent--fill-opaque/expected.png b/...macos/render-tests/combinations/hillshade-translucent--fill-opaque/expected.png
diff --git a/...cos/render-tests/combinations/raster-translucent--fill-translucent/expected.png b/...cos/render-tests/combinations/raster-translucent--fill-translucent/expected.png
diff --git a/...pectations/platform-macos/render-tests/fill-extrusion-base/default/expected.png b/...pectations/platform-macos/render-tests/fill-extrusion-base/default/expected.png
diff --git a/...ectations/platform-macos/render-tests/fill-extrusion-base/function/expected.png b/...ectations/platform-macos/render-tests/fill-extrusion-base/function/expected.png
diff --git a/...pectations/platform-macos/render-tests/fill-extrusion-base/literal/expected.png b/...pectations/platform-macos/render-tests/fill-extrusion-base/literal/expected.png
diff --git a/...ectations/platform-macos/render-tests/fill-extrusion-base/negative/expected.png b/...ectations/platform-macos/render-tests/fill-extrusion-base/negative/expected.png
diff --git a/...ns/platform-macos/render-tests/fill-extrusion-translate-anchor/map/expected.png b/...ns/platform-macos/render-tests/fill-extrusion-translate-anchor/map/expected.png
diff --git a/...atform-macos/render-tests/fill-extrusion-translate-anchor/viewport/expected.png b/...atform-macos/render-tests/fill-extrusion-translate-anchor/viewport/expected.png
diff --git a/...ectations/platform-macos/render-tests/sprites/2x-screen-2x-pattern/expected.png b/...ectations/platform-macos/render-tests/sprites/2x-screen-2x-pattern/expected.png
diff --git a/...ts/text-variable-anchor/left-top-right-bottom-offset-tile-map-mode/expected.png b/...ts/text-variable-anchor/left-top-right-bottom-offset-tile-map-mode/expected.png
diff --git a/...ons/platform-macos/render-tests/within/filter-with-inlined-geojson/expected.png b/...ons/platform-macos/render-tests/within/filter-with-inlined-geojson/expected.png
diff --git a/metrics/expectations/platform-macos/render-tests/within/paint-line/expected.png b/metrics/expectations/platform-macos/render-tests/within/paint-line/expected.png
diff --git a/metrics/ignores/platform-macos.json b/metrics/ignores/platform-macos.json
@@ -1,5 +1,10 @@
 {
     "render-tests/icon-image/icon-sdf-non-sdf-one-layer": "Failing on GitHub runner for unknown reason https://github.com/maplibre/maplibre-native/issues/377",
     "render-tests/regressions/mapbox-gl-js#5642": "Failing with mbgl-render-test",
-    "render-tests/regressions/mapbox-gl-js#7066": "Failing with mbgl-render-test"
+    "render-tests/regressions/mapbox-gl-js#7066": "Failing with mbgl-render-test",
+    "render-tests/text-field/formatted-images": "Needs to be investigated and fixed.",
+    "render-tests/symbol-visibility/visible": "Needs to be investigated and fixed.",
+    "render-tests/fill-outline-color/zoom-and-property-function": "It will be fixed after triangulated lines will support data driven properties",
+    "render-tests/fill-outline-color/property-function": "It will be fixed after triangulated lines will support data driven properties",
+    "render-tests/fill-extrusion-color/function": "Layer Z Fighting: https://github.com/maplibre/maplibre-native/issues/1847"
 }
diff --git a/metrics/macos-xcode11-release-metrics.json b/metrics/macos-xcode11-release-metrics.json
@@ -2,6 +2,7 @@
     "base_test_path": "tests",
     "cache_path": "cache-metrics.db",
     "expectation_paths": [
+	"expectations/platform-macos"
     ],
     "ignore_paths": [
         "ignores/platform-all.json",

diff --git a/metrics/macos-xcode11-release-style.json b/metrics/macos-xcode11-release-style.json
@@ -2,6 +2,7 @@
     "base_test_path": "integration",
     "cache_path": "cache-style.db",
     "expectation_paths": [
+	"expectations/platform-macos"
     ],
     "ignore_paths": [
         "ignores/platform-all.json",