Run Node.js ARM workflow on GitHub runner (#2859)

maplibre · Oct 7, 2024 · 64c8be5 · 64c8be5
1 parent d83c4ac
commit 64c8be5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml
@@ -3,6 +3,7 @@ self-hosted-runner:
   labels:
     - macos-14  # can be removed once actionlint is updated
     - ubuntu-24.04  # can be removed once actionlint is updated
+    - MapLibre_Native_Ubuntu_22_04_ARM_8_core
 # Configuration variables in array of strings defined in your repository or
 # organization. `null` means disabling configuration variables check.
 # Empty array means no configuration variable is allowed.

diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml
@@ -76,7 +76,7 @@ jobs:
         include:
           - runs-on: ubuntu-22.04
             arch: x86_64
-          - runs-on: [self-hosted, linux, ARM64]
+          - runs-on: MapLibre_Native_Ubuntu_22_04_ARM_8_core
             arch: arm64
           - runs-on: macos-14
             arch: arm64

diff --git a/.github/workflows/node-release.yml b/.github/workflows/node-release.yml
@@ -46,7 +46,7 @@ jobs:
         include:
           - runs-on: ubuntu-22.04
             arch: x86_64
-          - runs-on: [self-hosted, linux, ARM64]
+          - runs-on: MapLibre_Native_Ubuntu_22_04_ARM_8_core
             arch: arm64
           - runs-on: macos-14
             arch: arm64

diff --git a/test/util/memory.test.cpp b/test/util/memory.test.cpp
@@ -34,15 +34,15 @@ class MemoryTest {
 public:
     MemoryTest() {
         fileSource->styleResponse = [&](const Resource& res) {
-            auto resName = "style_" + getType(res) + ".json";
+            auto resName = std::string("style_") + getType(res) + ".json";
             return response(resName);
         };
         fileSource->tileResponse = [&](const Resource& res) {
             auto resName = getType(res) + ".tile";
             return response(resName);
         };
         fileSource->sourceResponse = [&](const Resource& res) {
-            auto resName = "source_" + getType(res) + ".json";
+            auto resName = std::string("source_") + getType(res) + ".json";
             return response(resName);
         };
         fileSource->glyphsResponse = [&](const Resource&) {