Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write negative numbers as sint, not plain int, to save tile space #60

Open
wants to merge 2 commits into
base: 2.x_updated_vtzero
Choose a base branch
from
Open

Write negative numbers as sint, not plain int, to save tile space #60

wants to merge 2 commits into from

Conversation

e-n-f
Copy link

@e-n-f e-n-f commented Apr 14, 2021

No description provided.

@e-n-f e-n-f self-assigned this Apr 14, 2021
allisonzheng
allisonzheng approved these changes Apr 15, 2021
View reviewed changes
Copy link

@allisonzheng allisonzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@e-n-f
Copy link
Author

e-n-f commented Apr 26, 2021

This is the check in Tippecanoe that does essentially the same thing, to write positive integers as uint or int but negative numbers as sint: https://github.com/mapbox/tippecanoe/blob/18e53cd7fb/mvt.cpp#L596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonzheng allisonzheng allisonzheng approved these changes

Assignees

@e-n-f e-n-f

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @allisonzheng