Write default values to oneof field anyway

mapbox · Jul 4, 2024 · 1bd1770 · 1bd1770
1 parent 1d724b1
commit 1bd1770
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/compile.js b/compile.js
@@ -401,7 +401,7 @@ function getDefaultWriteTest(ctx, field) {
     let code = `    if (obj.${field.name}`;
 
     if (!field.repeated && (!type || !type._proto.fields)) {
-        if (def === undefined || def) {
+        if (def === undefined || def || field.oneof) {
             code += ' != null';
         }
         if (def) {

diff --git a/test/compile.test.js b/test/compile.test.js
@@ -234,6 +234,15 @@ test('sets oneof field name', () => {
 
     assert.equal(data.value, 'float');
     assert.equal(data[data.value], 1.5);
+
+    pbf = new Pbf();
+    writeEnvelope({
+        float: 0
+    }, pbf);
+    data = readEnvelope(new Pbf(pbf.finish()));
+
+    assert.equal(data.value, 'float');
+    assert.equal(data[data.value], 0);
 });
 
 test('handles jstype=JS_STRING', () => {