Bugfix/point in polygon #1894
Open
Bugfix/point in polygon #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#1893
Description of changes
The current algorithm is based on https://stackoverflow.com/a/7123291
However, that algorithm fails when checking a point near the center of the polygon.
Just below that answer is https://stackoverflow.com/a/14998816
While I don't love that it still takes a list of lists, I have not changed that in order to maintain backwards-compatibility (see: #1873)
I'm not sure where tests would be added - I don't see any existing tests. Happy to add what's listed in the issue as a regression test if you can point me to where that'd be appropriate.
QA checklists
<summary>description as well as description of parameters.Reviewers
Not sure who to tag.