changed minus sign to a plus sign #1316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Israelkariti Mar 21, 2:41 PM PDT In class: "RotateWithLocationProvider" In method "Vector3 getNewEulerAngles(float newAngle)" Code at line 152 : "euler.y = -newAngle;" causing the player game object to turn CCW when the android device is actully turning CW (and vice versa) should be : "euler.y = newAngle;"
from 'TileJSONReponse' to 'TileJSONResponse'
|
Fixed typo in file name |
|
@atripathi-mb @jordy-isaac I'm not able to test this as it requires an android device (device rotation etc), can you give it a shot? |
|
@brnkhy It can be tested with any device. |
|
Unclear to me why this hasn't been merged in by now, as someone who is trying to use Mapbox for the first time, struggling with this over a long period of time sours an otherwise positive experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Israelkariti
Mar 21, 2:41 PM PDT
In class: "RotateWithLocationProvider"
In method "Vector3 getNewEulerAngles(float newAngle)"
Code at line 152 : "euler.y = -newAngle;"
causing the player game object to turn CCW when the android device is actully turning CW (and vice versa)
should be : "euler.y = newAngle;"
Related issue
Example: Closes #832. Relates to #832.
Description of changes
Your text here!
QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.