Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing heatmap example #2268

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixing heatmap example #2268

wants to merge 3 commits into from

Conversation

AndrewSepic
Copy link

@AndrewSepic AndrewSepic commented Dec 3, 2024

Changes in this PR

This PR fixes errors in the HeatmapLayerGlobeExample.swift file which was causing the circle Layer to not render on the map. This was discovered when I was working on creating an example description for this example in this PR and realized that the createCircleLayer() was failing to render.

The error had 2 causes

  1. createCircleLayer() declares the Earthquakes source after it is already declared above
  2. The interpolate function requires literal numeric values and this was using expressions.
  3. Interpolate requires numeric literals in strictly ascending order and this example included 2 steps with the value of 1.

All of the above errors are fixed in this PR.

Pull request checklist:

  • Describe the changes in this PR, especially public API changes.
  • Include before/after visuals or gifs if this PR includes visual changes.
Before After
Screenshot 2024-12-03 at 10 58 27 AM Screenshot 2024-12-03 at 10 56 28 AM

Video with transition of layers

Screen.Recording.2024-12-03.at.10.52.40.AM.mov

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@AndrewSepic AndrewSepic self-assigned this Dec 3, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AndrewSepic AndrewSepic marked this pull request as ready for review December 3, 2024 16:15
@AndrewSepic AndrewSepic requested a review from a team as a code owner December 3, 2024 16:15
@AndrewSepic AndrewSepic requested a review from evil159 December 3, 2024 16:15
nflahavan pushed a commit to RayaTheApp/mapbox-maps-ios that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants