Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateGeoJSONSource not working after update #2269

Open
almindurmis opened this issue Dec 16, 2024 · 1 comment
Open

updateGeoJSONSource not working after update #2269

almindurmis opened this issue Dec 16, 2024 · 1 comment
Labels
bug 🪲 Something is broken!

Comments

@almindurmis
Copy link

Environment

  • Xcode version: 16.2
  • iOS version: 17.5
  • Devices affected: iPhone 15 Pro
  • Maps SDK Version: 11.8.0

Observed behavior and steps to reproduce

After update to newer version of Mapbox, I had few things to refactor. Those were mostly changes in constructors of layers (example FillLayer, I had to add source ID). This is the list before and after:

BEFORE:
MapboxCommon (23.7.0)
MapboxCoreMaps (10.15.0):
MapboxCommon (~> 23.7)
MapboxMaps (10.15.0):
MapboxCommon (= 23.7.0)
MapboxCoreMaps (= 10.15.0)
MapboxMobileEvents (= 1.0.10)

AFTER:
MapboxCommon (24.8.0)
MapboxCoreMaps (11.8.0):
MapboxCommon (~> 24.8)
MapboxMaps (11.8.0):
MapboxCommon (= 24.8.0)
MapboxCoreMaps (= 11.8.0)
MapboxMobileEvents removed

Now, I have one really weird problem when I want to update MultiPolygon on the map. I'm using the same method as in older version and have two different outcomes (my brother still has the old version so we can test in paralel). I'm trying to make a "hole" in the layer and the logic that was working is this:

{
  "type": "MultiPolygon",
  "coordinates": [
    [
      {polygon},
      {hole},
      {hole},
      {hole}
    ]
  ]
}

With the same code I get the different results. Check the screenshots. The only difference in code is that I removed .style since it is deprecated now and removed do-catch. Ignore coordinates and sourceType parameters of the method for now since I don't use those in this hard-coded example.

Expected behavior

I am expecting to see the "hole" in the pattern like before in older version of Mapbox.

Screenshot 2024-12-16 at 08 34 01
Screenshot 2024-12-16 at 08 37 09

@almindurmis almindurmis added the bug 🪲 Something is broken! label Dec 16, 2024
@OdNairy
Copy link
Contributor

OdNairy commented Dec 16, 2024

Hi @almindurmis,
Thanks for the report. Could I ask you to make a sample project to reproduce the issue? That would significantly boost us to get into the issue resolution.

nflahavan pushed a commit to RayaTheApp/mapbox-maps-ios that referenced this issue Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something is broken!
Projects
None yet
Development

No branches or pull requests

2 participants