Use constant test values in locations tests, update fixtures (mapbox#…

…2269) Co-authored-by: Release SDK bot for Maps SDK team <[email protected]>
RayaTheApp · Aug 30, 2024 · 7016454 · 7016454
1 parent b724094
commit 7016454
Show file tree

Hide file tree

Showing 36 changed files with 228 additions and 175 deletions.
diff --git a/Tests/MapboxMapsTests/Foundation/CameraStateTests.swift b/Tests/MapboxMapsTests/Foundation/CameraStateTests.swift
@@ -11,7 +11,7 @@ final class CameraStateTests: XCTestCase {
 
     override func setUp() {
         super.tearDown()
-        center = .random()
+        center = .testConstantValue()
         padding = .random()
         anchor = CGPoint(
             x: .random(in: 0...100),

diff --git a/Tests/MapboxMapsTests/Foundation/Extensions/Core/FeatureExtensionValueTests.swift b/Tests/MapboxMapsTests/Foundation/Extensions/Core/FeatureExtensionValueTests.swift
@@ -15,7 +15,7 @@ final class FeatureExtensionValueTests: XCTestCase {
     func testInitializationWithWithNonNilValues() throws {
         let value = Int.random(in: 0..<100)
         let features = Array.random(withLength: .random(in: 0..<10)) { () -> Feature in
-            var feature = Feature(geometry: Point(.random()))
+            var feature = Feature(geometry: Point(.testConstantValue()))
             feature.identifier = .number(Double(Int.random(in: (.min)...(.max))))
             return feature
         }
@@ -38,7 +38,7 @@ final class FeatureExtensionValueTests: XCTestCase {
 
     func testNonNilFeatures() {
         let features = Array.random(withLength: .random(in: 0..<10)) { () -> Feature in
-            var feature = Feature(geometry: Point(.random()))
+            var feature = Feature(geometry: Point(.testConstantValue()))
             feature.identifier = .number(Double(Int.random(in: (.min)...(.max))))
             return feature
         }.map(MapboxCommon.Feature.init(_:))

diff --git a/Tests/MapboxMapsTests/Foundation/Extensions/Core/OfflineRegionGeometryDefinitionTests.swift b/Tests/MapboxMapsTests/Foundation/Extensions/Core/OfflineRegionGeometryDefinitionTests.swift
@@ -14,7 +14,7 @@ final class OfflineRegionGeometryDefinitionTests: XCTestCase {
     override func setUp() {
         super.setUp()
         styleURL = .randomASCII(withLength: .random(in: 0...50))
-        coordinate = .random()
+        coordinate = .testConstantValue()
         minZoom = .random(in: 0..<10)
         maxZoom = .random(in: 10...20)
         // swiftlint:disable:next syntactic_sugar

diff --git a/Tests/MapboxMapsTests/Foundation/Extensions/Turf/FeatureTests.swift b/Tests/MapboxMapsTests/Foundation/Extensions/Turf/FeatureTests.swift
@@ -3,7 +3,7 @@ import XCTest
 
 final class FeatureTests: XCTestCase {
 
-    let geometry = Geometry.point(Point(.random()))
+    let geometry = Geometry.point(Point(.testConstantValue()))
 
     func testInitializingTurfFeatureFromCommonFeatureNilIdentifier() throws {
         let commonFeature = MapboxCommon.Feature(

diff --git a/Tests/MapboxMapsTests/Foundation/Helpers/CLLocationCoordinate2DCodable.test.swift b/Tests/MapboxMapsTests/Foundation/Helpers/CLLocationCoordinate2DCodable.test.swift
@@ -45,7 +45,7 @@ class CLLocationCoordinate2DCodableTest: XCTestCase {
     }
 
     func testCoreLocationCoordinatesConversion() throws {
-        let coordinates: CLLocationCoordinate2D = .random()
+        let coordinates: CLLocationCoordinate2D = .testConstantValue()
         let codableCoordinates = CLLocationCoordinate2DCodable(coordinates)
 
         XCTAssertEqual(coordinates, codableCoordinates.coordinates)

diff --git a/Tests/MapboxMapsTests/Foundation/Interpolators/CoordinateInterpolatorTests.swift b/Tests/MapboxMapsTests/Foundation/Interpolators/CoordinateInterpolatorTests.swift
@@ -24,8 +24,8 @@ final class CoordinateInterpolatorTests: XCTestCase {
     }
 
     func testInterpolate() throws {
-        let from = CLLocationCoordinate2D.random()
-        let to = CLLocationCoordinate2D.random()
+        let from = CLLocationCoordinate2D.testConstantValue()
+        let to = CLLocationCoordinate2D.testConstantValue()
         let fraction = Double.random(in: 0...1)
         doubleInterpolator.interpolateStub.defaultReturnValue = .random(in: 0..<100)
         longitudeInterpolator.interpolateStub.defaultReturnValue = .random(in: 0..<100)

diff --git a/Tests/MapboxMapsTests/Foundation/Interpolators/Mocks/MockCoordinateInterpolator.swift b/Tests/MapboxMapsTests/Foundation/Interpolators/Mocks/MockCoordinateInterpolator.swift
@@ -8,7 +8,7 @@ final class MockCoordinateInterpolator: CoordinateInterpolatorProtocol {
         var to: CLLocationCoordinate2D
         var fraction: Double
     }
-    let interpolateStub = Stub<InterpolateParams, CLLocationCoordinate2D>(defaultReturnValue: .random())
+    let interpolateStub = Stub<InterpolateParams, CLLocationCoordinate2D>(defaultReturnValue: .testConstantValue())
     func interpolate(from: CLLocationCoordinate2D, to: CLLocationCoordinate2D, fraction: Double) -> CLLocationCoordinate2D {
         interpolateStub.call(with: .init(from: from, to: to, fraction: fraction))
     }

diff --git a/Tests/MapboxMapsTests/Foundation/MapboxMapTests.swift b/Tests/MapboxMapsTests/Foundation/MapboxMapTests.swift
@@ -382,7 +382,7 @@ final class MapboxMapTests: XCTestCase {
             tileId: nil,
             timestamp: Date())
         let cameraChanged = CameraChanged(
-            cameraState: CameraState(center: .random(), padding: .random(), zoom: 0, bearing: 0, pitch: 0),
+            cameraState: CameraState(center: .testConstantValue(), padding: .random(), zoom: 0, bearing: 0, pitch: 0),
             timestamp: Date())
 
         checkEvent(\.onMapIdle, \.onMapIdle, value: MapIdle(timestamp: Date()))

diff --git a/Tests/MapboxMapsTests/Foundation/Mocks/MockMapboxMap.swift b/Tests/MapboxMapsTests/Foundation/Mocks/MockMapboxMap.swift
@@ -48,7 +48,7 @@ final class MockMapboxMap: MapboxMapProtocol {
         setCameraStub.call(with: cameraOptions)
     }
 
-    let coordinateForPointStub = Stub<CGPoint, CLLocationCoordinate2D>(defaultReturnValue: .random())
+    let coordinateForPointStub = Stub<CGPoint, CLLocationCoordinate2D>(defaultReturnValue: .testConstantValue())
     func coordinate(for point: CGPoint) -> CLLocationCoordinate2D {
         coordinateForPointStub.call(with: point)
     }

diff --git a/Tests/MapboxMapsTests/Foundation/Random/CameraOptions+Random.swift b/Tests/MapboxMapsTests/Foundation/Random/CameraOptions+Random.swift
@@ -13,7 +13,7 @@ extension CameraOptions {
     }
     static func random() -> Self {
         return CameraOptions(
-            center: .random(),
+            center: .testConstantValue(),
             padding: .random(),
             anchor: .random(),
             zoom: .random(in: 0...20),

diff --git a/Tests/MapboxMapsTests/Foundation/Random/CameraState+Random.swift b/Tests/MapboxMapsTests/Foundation/Random/CameraState+Random.swift
@@ -14,7 +14,7 @@ extension CameraState {
 
     static func random() -> Self {
         return CameraState(
-            center: .random(),
+            center: .testConstantValue(),
             padding: .random(),
             zoom: .random(in: 0...20),
             bearing: .random(in: 0..<360),

diff --git a/Tests/MapboxMapsTests/Foundation/Style/StyleSourceManagerTests.swift b/Tests/MapboxMapsTests/Foundation/Style/StyleSourceManagerTests.swift
@@ -452,7 +452,7 @@ final class StyleSourceManagerTests: XCTestCase {
         // given
         let sourceId = String.randomASCII(withLength: 10)
         let dataId = String.randomASCII(withLength: 11)
-        let point = Point(.random())
+        let point = Point(.testConstantValue())
         let featureIdentifier = Double.random(in: 0...1000)
         var feature = Feature.init(geometry: point.geometry)
         feature.identifier = .number(featureIdentifier)
@@ -476,7 +476,7 @@ final class StyleSourceManagerTests: XCTestCase {
         // given
         let sourceId = String.randomASCII(withLength: 10)
         let dataId = String.randomASCII(withLength: 11)
-        let point = Point(.random())
+        let point = Point(.testConstantValue())
         let featureIdentifier = Double.random(in: 0...1000)
         var feature = Feature.init(geometry: point.geometry)
         feature.identifier = .number(featureIdentifier)
@@ -499,7 +499,7 @@ final class StyleSourceManagerTests: XCTestCase {
     func testPartialUpdateAPIsDontCancelPreviousUpdates() throws {
         // given
         let sourceId = String.randomASCII(withLength: 10)
-        let point = Point(.random())
+        let point = Point(.testConstantValue())
         let featureIdentifier = Double.random(in: 0...1000)
         var feature = Feature.init(geometry: point.geometry)
         feature.identifier = .number(featureIdentifier)
@@ -520,7 +520,7 @@ final class StyleSourceManagerTests: XCTestCase {
     func testFullUpdateAPIsCancelsAllPreviousUpdates() throws {
         // given
         let sourceId = String.randomASCII(withLength: 10)
-        let point = Point(.random())
+        let point = Point(.testConstantValue())
         let featureIdentifier = Double.random(in: 0...1000)
         var feature = Feature.init(geometry: point.geometry)
         feature.identifier = .number(featureIdentifier)

diff --git a/Tests/MapboxMapsTests/Foundation/Style/StyleTests.swift b/Tests/MapboxMapsTests/Foundation/Style/StyleTests.swift
@@ -422,13 +422,13 @@ final class StyleManagerTests: XCTestCase {
         styleManager.invalidateStyleCustomGeometrySourceRegionStub.defaultReturnValue = Expected(value: NSNull())
         XCTAssertNoThrow(try style.invalidateCustomGeometrySourceRegion(
             forSourceId: "dummy-source-id",
-            bounds: CoordinateBounds(southwest: .random(), northeast: .random()))
+            bounds: CoordinateBounds(southwest: .testConstantValue(), northeast: .testConstantValue()))
         )
 
         styleManager.invalidateStyleCustomGeometrySourceRegionStub.defaultReturnValue = Expected(error: "Cannot invalidate custom geometry source tile")
         XCTAssertThrowsError(try style.invalidateCustomGeometrySourceRegion(
             forSourceId: "dummy-source-id",
-            bounds: CoordinateBounds(southwest: .random(), northeast: .random()))
+            bounds: CoordinateBounds(southwest: .testConstantValue(), northeast: .testConstantValue()))
         )
     }
 
@@ -623,7 +623,7 @@ final class StyleManagerTests: XCTestCase {
         // given
         let sourceId = String.randomASCII(withLength: 10)
         let dataId = String.randomASCII(withLength: 11)
-        let point = Point(.random())
+        let point = Point(.testConstantValue())
         let featureIdentifier = Double.random(in: 0...1000)
         var feature = Feature.init(geometry: point.geometry)
         feature.identifier = .number(featureIdentifier)
@@ -643,7 +643,7 @@ final class StyleManagerTests: XCTestCase {
         // given
         let sourceId = String.randomASCII(withLength: 10)
         let dataId = String.randomASCII(withLength: 11)
-        let point = Point(.random())
+        let point = Point(.testConstantValue())
         let featureIdentifier = Double.random(in: 0...1000)
         var feature = Feature.init(geometry: point.geometry)
         feature.identifier = .number(featureIdentifier)

diff --git a/Tests/MapboxMapsTests/Helpers/Random/CLAccuracyAuthorization+Random.swift b/Tests/MapboxMapsTests/Helpers/Random/CLAccuracyAuthorization+Random.swift
diff --git a/Tests/MapboxMapsTests/Helpers/Random/CLLocationCoordinate2D+Random.swift b/Tests/MapboxMapsTests/Helpers/Random/CLLocationCoordinate2D+Random.swift
@@ -1,9 +1,9 @@
 import CoreLocation
 
 extension CLLocationCoordinate2D {
-    static func random() -> Self {
+    static func testConstantValue() -> Self {
         return CLLocationCoordinate2D(
-            latitude: .random(in: -90...90),
-            longitude: .random(in: -180..<180))
+            latitude: .testConstantValue(),
+            longitude: .testConstantValue())
     }
 }
diff --git a/Tests/MapboxMapsTests/Helpers/Random/UIColor+Random.swift b/Tests/MapboxMapsTests/Helpers/Random/UIColor+Random.swift
@@ -8,4 +8,12 @@ extension UIColor {
             blue: .random(in: 0...1),
             alpha: .random(in: 0...1))
     }
+
+    static func testConstantValue() -> UIColor {
+        return UIColor(
+            red: 0.1,
+            green: 0.2,
+            blue: 0,
+            alpha: 1)
+    }
 }
diff --git a/Tests/MapboxMapsTests/Location/AppleLocationProviderTests.swift b/Tests/MapboxMapsTests/Location/AppleLocationProviderTests.swift
@@ -120,8 +120,24 @@ final class AppleLocationProviderTests: XCTestCase {
     }
 #endif
 
-    func testAddingALocationConsumerDoesNotRequestWhenInUseAuthorizationForOtherStatuses() {
-        locationManager.compatibleAuthorizationStatus = [.restricted, .denied, .authorizedWhenInUse].randomElement()!
+    func testAddingALocationConsumerDoesNotRequestWhenInUseAuthorizationForOtherStatusesRestricted() {
+        locationManager.compatibleAuthorizationStatus = .restricted
+
+        _ = locationProvider.onLocationUpdate.observe { _ in }
+
+        XCTAssertTrue(locationManager.requestWhenInUseAuthorizationStub.invocations.isEmpty)
+    }
+
+    func testAddingALocationConsumerDoesNotRequestWhenInUseAuthorizationForOtherStatusesDenied() {
+        locationManager.compatibleAuthorizationStatus = .denied
+
+        _ = locationProvider.onLocationUpdate.observe { _ in }
+
+        XCTAssertTrue(locationManager.requestWhenInUseAuthorizationStub.invocations.isEmpty)
+    }
+
+    func testAddingALocationConsumerDoesNotRequestWhenInUseAuthorizationForOtherStatusesAuthWhenInUse() {
+        locationManager.compatibleAuthorizationStatus = .authorizedWhenInUse
 
         _ = locationProvider.onLocationUpdate.observe { _ in }
 
@@ -191,8 +207,8 @@ final class AppleLocationProviderTests: XCTestCase {
         XCTAssertEqual(observedViaObjectAPI, observed)
         XCTAssertEqual(locationProvider.latestHeading, nil)
 
-        let heading1 = Heading.random()
-        let heading2 = Heading.random()
+        let heading1 = Heading.testConstantValue()
+        let heading2 = Heading.testConstantValue()
 
         let clHeading1 = MockHeading()
         clHeading1.trueHeadingStub.defaultReturnValue = heading1.direction
@@ -215,7 +231,7 @@ final class AppleLocationProviderTests: XCTestCase {
 #endif
 
     func testConsumersAreNotifiedOfNewAccuracyAuthorizationsAfterLatestLocationIsUpdated() {
-        let coordinate = CLLocationCoordinate2D.random()
+        let coordinate = CLLocationCoordinate2D.testConstantValue()
         let clLocation = CLLocation(latitude: coordinate.latitude, longitude: coordinate.longitude)
         let accuracyAuthorization = CLAccuracyAuthorization.reducedAccuracy
 
@@ -306,7 +322,7 @@ final class AppleLocationProviderTests: XCTestCase {
 
     func testDidChangeAuthorizationNotifiesDelegateIfAccuracyAuthorizationChanged() {
         let accuracyAuthorizationValues: [CLAccuracyAuthorization] = [.fullAccuracy, .reducedAccuracy]
-        let initialIndex = Int.random(in: 0...1)
+        let initialIndex = 0
         let changedIndex = (initialIndex + 1) % 2 // the other one
         locationManager.compatibleAccuracyAuthorization = accuracyAuthorizationValues[initialIndex]
         locationProvider = AppleLocationProvider(
@@ -326,8 +342,8 @@ final class AppleLocationProviderTests: XCTestCase {
         XCTAssertEqual(delegate.didChangeAccuracyAuthorizationStub.invocations.first?.parameters.accuracyAuthorization, locationManager.compatibleAccuracyAuthorization)
     }
 
-    func testDidChangeAuthorizationDoesNotNotifyDelegateIfAccuracyAuthorizationDidNotChange() {
-        locationManager.compatibleAccuracyAuthorization = [.fullAccuracy, .reducedAccuracy].randomElement()!
+    func testDidChangeAuthorizationDoesNotNotifyDelegateIfAccuracyAuthorizationDidNotChangeFull() {
+        locationManager.compatibleAccuracyAuthorization = .fullAccuracy
         locationProvider = AppleLocationProvider(
             locationManager: locationManager,
             interfaceOrientation: $interfaceOrientation,
@@ -342,6 +358,22 @@ final class AppleLocationProviderTests: XCTestCase {
         XCTAssertEqual(delegate.didChangeAccuracyAuthorizationStub.invocations.count, 0)
     }
 
+    func testDidChangeAuthorizationDoesNotNotifyDelegateIfAccuracyAuthorizationDidNotChangeReduced() {
+        locationManager.compatibleAccuracyAuthorization = .reducedAccuracy
+        locationProvider = AppleLocationProvider(
+            locationManager: locationManager,
+            interfaceOrientation: $interfaceOrientation,
+            mayRequestWhenInUseAuthorization: true,
+            locationManagerDelegateProxy: locationManagerDelegateProxy)
+        delegate = MockLocationProducerDelegate()
+        locationProvider.delegate = delegate
+        addNoopLocationObserver()
+
+        locationProvider.locationManagerDidChangeAuthorization(CLLocationManager())
+
+        XCTAssertEqual(delegate.didChangeAccuracyAuthorizationStub.invocations.count, 0)
+    }
+
     func testRequestsTemporaryFullAccuracyAuthorizationWhenAccuracyIsReduced() {
         addNoopLocationObserver()
         locationManager.compatibleAuthorizationStatus = .authorizedWhenInUse
@@ -358,9 +390,29 @@ final class AppleLocationProviderTests: XCTestCase {
         }
     }
 
-    func testDoesNotRequestTemporaryFullAccuracyAuthorizationIfPermissionsNotGranted() {
+    func testDoesNotRequestTemporaryFullAccuracyAuthorizationIfPermissionsNotGrantedNotDetermined() {
+        addNoopLocationObserver()
+        locationManager.compatibleAuthorizationStatus = .notDetermined
+        locationManager.compatibleAccuracyAuthorization = .reducedAccuracy
+
+        locationProvider.locationManagerDidChangeAuthorization(CLLocationManager())
+
+        XCTAssertTrue(locationManager.requestTemporaryFullAccuracyAuthorizationStub.invocations.isEmpty)
+    }
+
+    func testDoesNotRequestTemporaryFullAccuracyAuthorizationIfPermissionsNotGrantedRestricted() {
+        addNoopLocationObserver()
+        locationManager.compatibleAuthorizationStatus = .restricted
+        locationManager.compatibleAccuracyAuthorization = .reducedAccuracy
+
+        locationProvider.locationManagerDidChangeAuthorization(CLLocationManager())
+
+        XCTAssertTrue(locationManager.requestTemporaryFullAccuracyAuthorizationStub.invocations.isEmpty)
+    }
+
+    func testDoesNotRequestTemporaryFullAccuracyAuthorizationIfPermissionsNotGrantedDenied() {
         addNoopLocationObserver()
-        locationManager.compatibleAuthorizationStatus = [.notDetermined, .restricted, .denied].randomElement()!
+        locationManager.compatibleAuthorizationStatus = .denied
         locationManager.compatibleAccuracyAuthorization = .reducedAccuracy
 
         locationProvider.locationManagerDidChangeAuthorization(CLLocationManager())
@@ -434,8 +486,8 @@ final class AppleLocationProviderTests: XCTestCase {
 
     func testOptions() {
         // given
-        let options = AppleLocationProvider.Options(distanceFilter: .random(in: 0...10_000),
-                                                    desiredAccuracy: .random(in: 0...1000),
+        let options = AppleLocationProvider.Options(distanceFilter: 45890,
+                                                    desiredAccuracy: 783,
                                                     activityType: .other)
         // when
         locationProvider.options = options

diff --git a/Tests/MapboxMapsTests/Location/Fixtures/Location+Fixtures.swift b/Tests/MapboxMapsTests/Location/Fixtures/Location+Fixtures.swift
@@ -0,0 +1,32 @@
+import MapboxMaps
+import MapboxCommon
+
+extension Location {
+    static func testConstantValue() -> Location {
+        Location(
+            coordinate: .testConstantValue(),
+            timestamp: Date(),
+            bearing: .testConstantValue(),
+            bearingAccuracy: .testConstantValue()
+        )
+    }
+}
+
+extension Heading {
+    static func testConstantValue() -> Heading {
+        Heading(direction: .testConstantValue(),
+                accuracy: .testSourceValue())
+    }
+}
+
+extension PuckRenderingData {
+    static func testConstantValue() -> PuckRenderingData {
+        PuckRenderingData(location: .testConstantValue(), heading: .testConstantValue())
+    }
+}
+
+extension CLAccuracyAuthorization {
+    static func testConstantValue() -> Self {
+        return .reducedAccuracy
+    }
+}
diff --git a/Tests/MapboxMapsTests/Location/LocationInterpolatorTests.swift b/Tests/MapboxMapsTests/Location/LocationInterpolatorTests.swift
@@ -15,7 +15,7 @@ final class LocationInterpolatorTests: XCTestCase {
         var result = me.interpolate(from: [], to: [], fraction: 1)
         XCTAssertEqual(result, [])
 
-        let l1 = Location.random()
+        let l1 = Location.testConstantValue()
         result = me.interpolate(from: [l1], to: [], fraction: 1)
         XCTAssertEqual(result, [])