Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate worker, CPU and Memory alarms #399

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

mappingvermont
Copy link
Collaborator

This PR attaches the stack name to worker, CPU and Memory alarms to allow for multiple watchbot stacks in a given AWS account.

There's no JIRA ticket for this - @macro-shen identified it when building a stack in an account that had already had a watchbot v10 stack in it.

Resource name changes:

  • Watchbot-QueueProcessingFargateService-CPU-Usage-cpu ➡️ mapbox-places-charlie-QueueProcessingFargateService-CPU-Usage-cpu
  • Watchbot-QueueProcessingFargateService-Memory-Usage-memoryUsage ➡️ mapbox-places-charlie-QueueProcessingFargateService-Memory-Usage-memoryUsage
  • Watchbot-worker-errors-us-east-1-error ➡️ mapbox-places-charlie-worker-errors-us-east-1-error

Checklist

Complete the steps below before merge where applicable:

  • I included JIRA ticket code in the PR header
  • I read and understood the CONTRIBUTING.md doc.
  • I used conventional commits for the PR title.
  • I used proper typescript comments to document the changes made
  • I made changes to relevant tests or added new tests if applicable
  • I updated the package.json, package-lock.json and readme.md to reflect the new correct Watchbot version
    • DO NOT MERGE WITHOUT MAKING THESE CHANGES
  • I updated the changelog.md

@mappingvermont mappingvermont requested a review from a team as a code owner October 18, 2024 13:26
@mappingvermont mappingvermont merged commit fc908ce into master Oct 18, 2024
4 checks passed
@mappingvermont mappingvermont deleted the disambiguate-worker-alarm branch October 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants