-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Editor: add example config files #512
Conversation
AppVeyor build 1.0.339 for commit 33e2bdf is now complete. Found 51 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscingcontent/02.delete-me.md:44:aliqua content/02.delete-me.md:44:amet content/02.delete-me.md:44:consectetur content/02.delete-me.md:44:dolore content/02.delete-me.md:44:eiusmod content/02.delete-me.md:44:elit content/02.delete-me.md:44:incididunt content/02.delete-me.md:44:ipsum content/02.delete-me.md:44:labore content/02.delete-me.md:44:Lorem content/02.delete-me.md:44:magna content/02... |
content/ai_revision-config.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think ai_revision-config.yaml
and ai_revision-prompts.yaml
belong under content
, which should remain primarily content that composes the manuscript.
I think ci
or less likely build
would be a more appropriate directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Daniel. I'll talk with @vincerubinetti and Faisal about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dhimmel, agreed; per your suggestion we've moved the config files to ci
rather than content
.
…them to ci folder rather than content
@dhimmel this PR is ready to be merged. @vincerubinetti maybe you can start testing this now. |
ci/ai-revision-prompts.yaml
Outdated
|
||
Input paragraph: {{ content }} | ||
|
||
Proofread paragraph: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing final newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
@dhimmel note that doing a fresh fork of rootstock failed (for the ai editor) because the manubot package is specified as a specific commit rather than a semver or github@latest version. That will be need to be updated as well. It also seems like a new PIPY version should be pushed, and that rootstock should be based off of PYPI, but I'll leave that to you. |
From this, I understand that following the instructions to create a new Manubot-based manuscript (fork of this repo) and run the AI Editor would fail, right? |
This pull request should have incremented the manubot version for #513 upgrades the manubot version used in rootstock and should resolve the problem. I see the following as separate points as separate from the cause of this issue (and separate from eachother):
|
merges manubot#512 Co-authored-by: Faisal Alquaddoomi <[email protected]>
merges manubot/rootstock#512 Co-authored-by: Faisal Alquaddoomi <[email protected]>
No description provided.