Fix vtt exception

mantas-done · Aug 27, 2023 · 7fac608 · 7fac608
1 parent 4dc2654
commit 7fac608
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Code/Converters/VttConverter.php b/src/Code/Converters/VttConverter.php
@@ -96,6 +96,9 @@ protected static function vttTimeToInternal($vtt_time)
         // parts[0] could be mm:ss or hh:mm:ss format -> always use hh:mm:ss
         $parts[0] = substr_count($parts[0], ':') == 2 ? $parts[0] : '00:'.$parts[0];
 
+        if (!isset($parts[1])) {
+            throw new UserException("Time doesn't have milliseconds: " . $vtt_time);
+        }
         $only_seconds = strtotime("1970-01-01 {$parts[0]} UTC");
         $milliseconds = (float)('0.' . $parts[1]);
 

diff --git a/tests/formats/VttTest.php b/tests/formats/VttTest.php
@@ -90,6 +90,21 @@ public function testParsesFileWithCue()
         $this->assertInternalFormatsEqual($expected, $actual);
     }
 
+    public function testExceptionIfWrongTimestamp()
+    {
+        $this->expectException(UserException::class);
+
+        $input_vtt_file_content = <<< TEXT
+WEBVTT
+
+1
+00:00:00.00 --> 00:00:01.o0
+a
+TEXT;
+
+        Subtitles::loadFromString($input_vtt_file_content)->getInternalFormat();
+    }
+
     public function testNoExceptionWhenEmptyFile()
     {
         $this->expectException(UserException::class);