Simple Matlab functions for post-simulation verification #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approve |
| @@ -0,0 +1,3 @@ | |||
| function res = squareIt(value) | |||
There was a problem hiding this comment.
Code smell. Why is this almost trivial helper function necessary? What is the advantage over just writing (expr)^2 when I need to square something?
There was a problem hiding this comment.
Just readability. There's cases where writing (expr)^2 would lead end up looking like ((aX * bX) + (aY * bY)) ^ 2, where it isn't immediately clear where the power is being applied (to me at least). Having the function is easier to look at, and understand, what's happening IMO, but I'm happy to change it if there's strong opposition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started creating a simple library of functions to verify our simulation results from dReal. Currently, this is just the Matlab code and I'm working on the Java code that will generate code to call these functions.