Correctly catch HttpException when retrieving item

Fixes openhab#3779 Signed-off-by: Danny Baumann <[email protected]>
maniac103 · Aug 14, 2024 · d8690d0 · d8690d0
1 parent a783be8
commit d8690d0
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/mobile/src/main/java/org/openhab/habdroid/background/ItemsControlsProviderService.kt b/mobile/src/main/java/org/openhab/habdroid/background/ItemsControlsProviderService.kt
@@ -120,7 +120,13 @@ class ItemsControlsProviderService : ControlsProviderService() {
         }
         val state = when (action) {
             is BooleanAction -> {
-                val item = ItemClient.loadItem(connection, itemName) ?: return ControlAction.RESPONSE_FAIL
+                val item = try {
+                    ItemClient.loadItem(connection, itemName)
+                } catch (e: HttpClient.HttpException) {
+                    Log.e(TAG, "Could not determine item type for boolean action", e)
+                    null
+                } ?: return ControlAction.RESPONSE_FAIL
+
                 if (item.isOfTypeOrGroupType(Item.Type.Player)) {
                     if (action.newState) "PLAY" else "PAUSE"
                 } else {