Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of internal OkHttp API #7

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Avoid use of internal OkHttp API #7

merged 1 commit into from
Dec 21, 2021

Conversation

Fs00
Copy link

@Fs00 Fs00 commented Dec 8, 2021

This will allow the app to be updated to OkHttp 4 when we raise minSdkVersion to 21.
Util.closeQuietly has been copied verbatim from OkHttp code, while Charset.defaultCharset() always returns UTF-8 charset on Android.

Fixes Meisolsson#30

@Fs00
Copy link
Author

Fs00 commented Dec 21, 2021

@maniac103 I've seen that you pushed a new version of the bindings, thanks! I'll update the app soon.
Will you publish a new version with this PR and #4? This one in particular should be very safe to merge, whereas #4 will need a bit of testing (which is impossible to do without a new version anyway).

@maniac103 maniac103 merged commit 507a347 into maniac103:gh4a-rebase Dec 21, 2021
@Fs00 Fs00 deleted the no-internals branch December 21, 2021 10:28
@maniac103
Copy link
Owner

Will you publish a new version with this PR and #4?

Done (tagged as 0.7.0.6).

@Fs00
Copy link
Author

Fs00 commented Dec 21, 2021

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants