fix(kandel): validate Kandel params for one sided trades. (#110)

* fix(kandel): validate Kandel params for one sided trades. * refactor: Remove console.log statement from validateKandelParams function. * refactor: Update validity check in view kandel test.
mangrovedao · Jul 16, 2024 · 5f6343e · 5f6343e
1 parent 3fec2c2
commit 5f6343e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/sixty-cups-roll.md b/.changeset/sixty-cups-roll.md
@@ -0,0 +1,5 @@
+---
+"@mangrovedao/mgv": patch
+---
+
+Fix validate kandel params when one sided
diff --git a/src/actions/kandel/view.test.ts b/src/actions/kandel/view.test.ts
@@ -126,7 +126,7 @@ describe('view kandel', () => {
       marketConfig: book.marketConfig,
     })
 
-    expect(isValid).toBe(false)
+    expect(isValid).toBe(true) // even though out of range, params are valid
 
     const kandel = await sowAndPopulate(params, minProvision)
 

diff --git a/src/lib/kandel/params.ts b/src/lib/kandel/params.ts
@@ -194,7 +194,8 @@ export function validateKandelParams(
     marketConfig.gasprice *
     BigInt(1e6)
 
-  const isValid = askGives >= minAsk && bidGives >= minBid
+  const isValid =
+    (nAsks === 0n || askGives >= minAsk) && (nBids === 0n || bidGives >= minBid)
 
   return {
     params: {