Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binja database support #2501

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xusheng6
Copy link
Contributor

@xusheng6 xusheng6 commented Nov 21, 2024

This PR adds support for loading and analyzing a binja database: #2496

There are two things I wish to mention:

  1. This PR is rebased on Various binja backend fixes #2500, rather then the latest master. I now realize this is not the best thing to do, but I cannot simply drop the commits from Various binja backend fixes #2500 because there are conflicts. So maybe first have a look at that PR, and if it gets approved, I can rebase this again (if needed)
  2. I did not add a unit test for this. I know I can save one of the file we use for unit tests to a binja database and then load it. Do you have a representative binary to use for it among those files? Also, should I add a new test or should I just add it to test_binja_features.py?

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@williballenthin
Copy link
Collaborator

Do you have a representative binary to use for it among those files? Also, should I add a new test or should I just add it to test_binja_features.py?

I think you should take a trivial file, like PMA 01-01.dll, and use that. The test only needs to show that the db file can be analyzed, not that all the features are extracted consistently (which we can assume will be the case, I think).

return False
return None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants