Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue template & automation for Node tools installed with npm #1046

Merged
merged 2 commits into from
May 16, 2024

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented May 16, 2024

Add new issue template to propose the addition of a new package/tool that is installed from the JavaScript Package Registry installed with npm install -g <tool_name>. The new issue template supports the send PR automation to create new packages automatically using the new NODE template. Improve and keep consistent the other new package templates.

In addition, we could add to the existent NEW PACKAGE from URL template Node packages installed with npm from a URL (such as GH repos). For this we can use the VM-Install-Node-Tool-From-Zip function. But it is a bit more complicated to implement than this case, as we would need to add an extra arguments or command parameter to the script and the template. This would be an improvement for the current package types as well. I suggest tracking this as a new issue and implementing it in multiple steps: add arguments parameter to scrip + current template, and then add to the existent NEW PACKAGE from URL template Node packages installed with npm from a URL.

You can see it working in Ana06#27

Closes #999

@Ana06 Ana06 changed the title NodAdd issue template & automation for Add issue template & automation for Node tools installed with npm May 16, 2024
@Ana06 Ana06 self-assigned this May 16, 2024
@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🏃 CI Related to CI labels May 16, 2024
@Ana06 Ana06 requested a review from a team May 16, 2024 12:30
Ana06 added 2 commits May 16, 2024 17:21
Add `NODE` template to the `create_package_template.py` script.
Add new issue template to propose the addition of a new package/tool
that is installed from the JavaScript Package Registry installed with
`npm install -g <tool_name>`. The new issue template supports the `send
PR` automation to create new packages automatically.

Improve and keep consistent the other _new package_ templates.
@Ana06
Copy link
Member Author

Ana06 commented May 16, 2024

Created issue for the idea mention above: #1047

@Ana06 Ana06 merged commit a55a78b into mandiant:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better 🏃 CI Related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create package template for Node tools
1 participant