Optionally skip printing the function sections #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new -no-functions command line flag to skip printing the UserFunctions and StdFunctions detailed sections. This is useful to get a quick summary of what is in a Go binary. The default is to always print the function sections. Reference: mandiant#49 Signed-off-by: Philippe Ombredanne <[email protected]>
stevemk14ebr
requested changes
Aug 1, 2024
main.go
Outdated
| } | ||
|
|
||
| func main_impl(fileName string, printStdPkgs bool, printFilePaths bool, printTypes bool, manualTypeAddress int, versionOverride string) (metadata ExtractMetadata, err error) { | ||
| func main_impl(fileName string, printStdPkgs bool, printFilePaths bool, printTypes bool, manualTypeAddress int, versionOverride string, noPrintFunctions bool) (metadata ExtractMetadata, err error) { |
There was a problem hiding this comment.
Lets move noPrintFunctions arg to right after printTypes for consistency with the order of where the rest of the output related args are.
main.go
Outdated
| @@ -425,6 +427,7 @@ func main() { | |||
| typeAddress := flag.Int("m", 0, "Manually parse the RTYPE at the provided virtual address, disables automated enumeration of moduledata typelinks itablinks") | |||
| versionOverride := flag.String("v", "", "Override the automated version detection, ex: 1.17. If this is wrong, parsing may fail or produce nonsense") | |||
| humanView := flag.Bool("human", false, "Human view, print information flat rather than json, some information is omitted for clarity") | |||
| noPrintFunctions := flag.Bool("no-functions", false, "Do not print user and standard function sections") | |||
There was a problem hiding this comment.
I don't like the dash here in the arg name. Lets choose something that's a single word, nofuncs works nice and is short.
|
Thanks for the PR, two small adjustments and I'll merge! |
Use -nofuncs command line flag instead. Reorder main_impl() function arguments. Reference: mandiant#49 Signed-off-by: Philippe Ombredanne <[email protected]>
stevemk14ebr
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
-no-functionscommand line flag to skip printing theUserFunctionsandStdFunctionsdetailed sections.This is useful to get a quick summary of what is in a Go binary.
The default is to always print the function sections.
Reference: #49
Signed-off-by: Philippe Ombredanne [email protected]