Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Unicode ASN Names and option to include accuracy radius in distance calculation #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sck-nogas
Copy link

Here's two quick fixes that I uncovered.

1 - The ASN names if they include Unicode like "TELEFÔNICA BRASIL S.A" would cause the program to crash since in Python2 str can't handle unicode.

2 - When calculating the distance between two location, sometimes the IP location is "approximate", and in some of my logs, the MaxMind DB was putting the location as (37.751, -97.822) which is in the middle of Cheney Reservoir outside, Wichita Kansas. When in reality the actual location was closer to Emeryville, CA. When looking into this issue, I noticed that for some IP address, MaxMind has a 1,000km accuracy radius. Therefore, to prevent over alerting, I included an option to take the accuracy into account.

@davidpany
Copy link
Collaborator

Thank you for identifying the Unicode issue, I've updated Version 1.01 to support Unicode ASNs. Please let me know if you have any additional questions.

Also, thanks for sharing the radius of accuracy information. I didn't know that existed but it seems extremely useful. I'll test out your pull request and hopefully get the feature included shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants