Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nfs test setup fail #2022

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix nfs test setup fail #2022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11e075d
Change mp start method
phoebusm Nov 26, 2024
c1e92f5
Add comment
phoebusm Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions python/arcticdb/storage_fixtures/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
import os
import re
import sys
import trustme
import subprocess
import platform
from tempfile import mkdtemp

Expand Down Expand Up @@ -339,7 +337,8 @@ def _start_server(self):
self.client_cert_file = ""
self.client_cert_dir = self.working_dir

self._p = multiprocessing.Process(
spawn_context = multiprocessing.get_context('spawn')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a comment explaining what the spawn_context is for and how it avoids the issue?

self._p = spawn_context.Process(
target=self.run_server,
args=(
port,
Expand Down Expand Up @@ -438,7 +437,7 @@ def cleanup_bucket(self, b: S3Bucket):

class MotoNfsBackedS3StorageFixtureFactory(MotoS3StorageFixtureFactory):

def create_fixture(self, default_prefix=None, use_raw_prefix=False) -> NfsS3Bucket:
def create_fixture(self) -> NfsS3Bucket:
bucket = f"test_bucket_{self._bucket_id}"
self._s3_admin.create_bucket(Bucket=bucket)
self._bucket_id += 1
Expand Down
2 changes: 0 additions & 2 deletions python/tests/integration/arcticdb/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def test_s3_running_on_aws_fast_check(lib_name, s3_storage_factory, run_on_aws):
assert lib_tool.inspect_env_variable("AWS_EC2_METADATA_DISABLED") == "true"


@pytest.mark.skip(reason="There is a flaky segfault in the test setup")
def test_nfs_backed_s3_storage(lib_name, nfs_backed_s3_storage):
# Given
lib = nfs_backed_s3_storage.create_version_store_factory(lib_name)()
Expand Down Expand Up @@ -94,7 +93,6 @@ def s3_storage_dots_in_path(request):
yield g


@pytest.mark.skip(reason="There is a flaky segfault in the test setup")
def test_read_path_with_dot(lib_name, s3_storage_dots_in_path):
# Given
factory = s3_storage_dots_in_path.create_version_store_factory(lib_name)
Expand Down
Loading