Drop Windows build on 4.4.x

.github/workflows/build.yml

@@ -59,17 +59,6 @@ jobs:
                   image: ghcr.io/man-group/arcticdb-dev:${{inputs.dev_image_tag || 'latest'}}
                   volumes:
                     - /:/mnt
-            windows_matrix:
-              - os: windows
-                distro: windows-latest
-                cmake_preset_prefix: windows-cl
-                cibw_build_suffix: win_amd64
-                build_dir: C:/cpp_build
-                vcpkg_packages_dir: C:/vcpkg_packages
-                symbols: "*.pdb" # Please update publish.yml when changing this!!
-                do_not_archive: ["*.lib", "*.ilk", "*.pyd", "*.dll", "CMakeFiles/*.dir", "vcpkg_installed"]
-                test_services: {}
-                container: null
     steps:
       - run: |
           if ${{startsWith(github.ref, 'refs/tags/v')}}; then
@@ -88,7 +77,6 @@ jobs:
       pypi_publish: ${{inputs.pypi_publish || env.PYPI_PUBLISH}}
       cmake_preset_type_resolved: ${{inputs.cmake_preset_type != '-' && inputs.cmake_preset_type || env.CMAKE_PRESET_TYPE}}
       linux_matrix: ${{toJson(matrix.linux_matrix)}}
-      windows_matrix: ${{toJson(matrix.windows_matrix)}}
 
   pre_seed_cleanup:
     if: inputs.persistent_storage == true
@@ -120,28 +108,6 @@ jobs:
       matrix: ${{toJson(matrix.matrix_override)}}
       python_deps_ids: ${{toJson(matrix.python_deps_ids)}}
 
-  persistent_storage_seed_windows:
-    needs: [common_config, pre_seed_cleanup]
-    if: inputs.persistent_storage == true
-    strategy:
-      fail-fast: false
-      matrix:
-        python3: ${{fromJson(vars.WINDOWS_PYTHON_VERSIONS || '[7, 8, 9, 10, 11]')}}
-        arcticdb_version: ["oldest", "latest"]
-        include:
-          - python_deps_ids: [""]
-            matrix_override: ${{fromJson(needs.common_config.outputs.windows_matrix)}}
-    name: Seed Persistent Storage for 3.${{matrix.python3}} Windows with ${{ matrix.arcticdb_version }} ArcticDB package version 
-    uses: ./.github/workflows/persistent_storage.yml
-    secrets: inherit
-    permissions: {packages: write}
-    with:
-      job_type: seed
-      python3: ${{matrix.python3}}
-      arcticdb_version: ${{matrix.arcticdb_version}}
-      matrix: ${{toJson(matrix.matrix_override)}}
-      python_deps_ids: ${{toJson(matrix.python_deps_ids)}}
-
   cpp-test-linux:
     needs: [cibw_docker_image, common_config]
     name: Linux C++ Tests
@@ -192,36 +158,8 @@ jobs:
       persistent_storage: ${{inputs.persistent_storage}}
       pytest_xdist_mode: ${{matrix.pytest_xdist_mode}}
 
-  cpp-test-windows:
-    needs: [common_config]
-    name: Windows C++ Tests
-    uses: ./.github/workflows/build_steps.yml
-    secrets: inherit
-    with:
-      job_type: cpp-tests
-      cmake_preset_type: ${{needs.common_config.outputs.cmake_preset_type_resolved}}
-      matrix: ${{needs.common_config.outputs.windows_matrix}}
-
-  build-python-wheels-windows:
-    needs: [common_config]
-    strategy:
-      fail-fast: false
-      matrix:
-        python3: ${{fromJson(vars.WINDOWS_PYTHON_VERSIONS || '[7, 8, 9, 10, 11]')}}
-    name: 3.${{matrix.python3}} Windows
-    uses: ./.github/workflows/build_steps.yml
-    secrets: inherit
-    permissions: {packages: write}
-    with:
-      job_type: build-python-wheels
-      python3: ${{matrix.python3}}
-      cibw_version: ${{needs.common_config.outputs.cibuildwheel_ver}}
-      cmake_preset_type: ${{needs.common_config.outputs.cmake_preset_type_resolved}}
-      matrix: ${{needs.common_config.outputs.windows_matrix}}
-      persistent_storage: ${{ inputs.persistent_storage }}
-
   persistent_storage_verify_linux:
-    needs: [common_config, build-python-wheels-linux, build-python-wheels-windows]
+    needs: [common_config, build-python-wheels-linux]
     if: inputs.persistent_storage == true
     strategy:
       fail-fast: false
@@ -242,30 +180,8 @@ jobs:
       matrix: ${{toJson(matrix.matrix_override)}}
       python_deps_ids: ${{toJson(matrix.python_deps_ids)}}
 
-  persistent_storage_verify_windows:
-    needs: [common_config, build-python-wheels-windows, build-python-wheels-linux]
-    if: inputs.persistent_storage == true
-    strategy:
-      fail-fast: false
-      matrix:
-        python3: ${{fromJson(vars.WINDOWS_PYTHON_VERSIONS || '[7, 8, 9, 10, 11]')}}
-        arcticdb_version: ["oldest", "latest"]
-        include:
-          - python_deps_ids: [""]
-            matrix_override: ${{fromJson(needs.common_config.outputs.windows_matrix)}}
-    name: Verify Persistent Storage for 3.${{matrix.python3}} Windows with ${{ matrix.arcticdb_version }} ArcticDB package version 
-    uses: ./.github/workflows/persistent_storage.yml
-    secrets: inherit
-    permissions: {packages: write}
-    with:
-      job_type: verify
-      python3: ${{matrix.python3}}
-      arcticdb_version: ${{matrix.arcticdb_version}}
-      matrix: ${{toJson(matrix.matrix_override)}}
-      python_deps_ids: ${{toJson(matrix.python_deps_ids)}}
-
   post_verify_cleanup:
-    needs: [persistent_storage_verify_windows, persistent_storage_verify_linux]
+    needs: persistent_storage_verify_linux
     if: inputs.persistent_storage == true
     name: Cleanup persistent storages
     uses: ./.github/workflows/persistent_storage.yml
@@ -274,7 +190,7 @@ jobs:
       job_type: cleanup
 
   can_merge:
-    needs: [cpp-test-linux, cpp-test-windows, build-python-wheels-linux, build-python-wheels-windows, persistent_storage_verify_linux, persistent_storage_verify_windows]
+    needs: [cpp-test-linux, build-python-wheels-linux, persistent_storage_verify_linux]
     if: |
       always() &&
       !failure() &&

.github/workflows/build_steps.yml

@@ -79,15 +79,6 @@ jobs:
         with:
           version: "v0.4.0"
 
-      - name: Windows Pagefile
-        if: matrix.os == 'windows'
-        uses: al-cheb/[email protected]
-        with:
-          minimum-size: 2GB
-          maximum-size: 6GB
-          disk-root: "D:"  # This is also the checkout directory. Total size 12GB.
-        continue-on-error: true
-
       - name: Extra envs
         # This has to come after msvc-dev-cmd to overwrite the bad VCPKG_ROOT it sets
         run: |
@@ -110,31 +101,10 @@ jobs:
           du -m /mnt/usr/local/lib/ | sort -n | tail -n 50
           nohup rm -rf /mnt/usr/local/lib/android &
 
-      - name: Find and remove ccache # See PR: #945
-        if: matrix.os == 'windows'
-        run: rm $(which ccache) || true
-
       - name: Prepare C++ compilation env
         if: inputs.job_type != 'build-python-wheels'
         run: . build_tooling/prep_cpp_build.sh # Also applies to Windows
 
-        # When a GitHub Windows image gets update the MSVC compiler also can get updated. New compilers can have compilation errors in Arctic or in the VCPKG dependencies.
-        # We needd to pin a particular MSVC so that runner updates don't affect us.
-        # When the MSVC version is update custom-triplets/x64-windows-static-msvc.cmake must also be updated with the correct toolsed version.
-      - name: Install Required MSVC
-        if: matrix.os == 'windows'
-        run: |
-          choco install -y -f visualstudio2022buildtools --version=117.11.4 --params "--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --installChannelUri https://aka.ms/vs/17/release/390666095_1317821361/channel"
-          choco install -y ninja
-
-      - name: Enable Windows compiler commands
-        if: matrix.os == 'windows'
-        uses: TheMrMilchmann/setup-msvc-dev@v3
-        with:
-          arch: x64
-          toolset: 14.41
-          vs-path: 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools'
-
       - name: CMake compile
         if: inputs.job_type != 'build-python-wheels'
         # We are pinning the version to 10.6 because >= 10.7, use node20 which is not supported in the container
@@ -295,21 +265,6 @@ jobs:
         if: matrix.os == 'linux'
         run: echo /opt/python/${{env.python_impl_name}}*/bin >> $GITHUB_PATH
 
-      - name: Select Python (Windows)
-        if: matrix.os == 'windows'
-        uses: actions/[email protected]
-        with:
-          python-version: "3.${{inputs.python3}}"
-
-      - name: Windows Pagefile
-        if: matrix.os == 'windows'
-        uses: al-cheb/[email protected]
-        with:
-          minimum-size: 2GB
-          maximum-size: 8GB
-          disk-root: "D:"  # This is also the checkout directory. Total size 12GB.
-        continue-on-error: true
-
       - name: Install npm # Linux github runner image does not come with npm
         if: matrix.os == 'linux'
         uses: actions/[email protected]
@@ -355,13 +310,6 @@ jobs:
           HYPOTHESIS_PROFILE: ci_${{matrix.os}}
           PYTEST_XDIST_MODE: ${{inputs.pytest_xdist_mode}}
 
-      - name: Collect crash dumps (Windows)
-        if: matrix.os == 'windows' && failure()
-        uses: actions/[email protected]
-        with:
-          name: crashdump-${{env.distinguishing_name}}
-          path: ${{env.LOCALAPPDATA}}/CrashDumps/
-
       - name: Disk usage
         if: always()
         run: set +e ; du -m . "${PARALLEL_TEST_ROOT:-/tmp/parallel_test}" | sort -n | tail -n 100 || true; df -h

.github/workflows/persistent_storage.yml

@@ -44,12 +44,6 @@ jobs:
         if: matrix.os == 'linux'
         run: echo /opt/python/${{env.python_impl_name}}*/bin >> $GITHUB_PATH
 
-      - name: Select Python (Windows)
-        if: matrix.os == 'windows'
-        uses: actions/[email protected]
-        with:
-          python-version: "3.${{inputs.python3}}"
-
       - name: Install latest release
         if: inputs.arcticdb_version == 'latest'
         run: |