Add compatibility with Noxy Multidirectional Trains #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's talk about this one in Discord a bit (https://discord.gg/pg6yQx8EXV) if you don't mind. I think a well defined api for teleporting trains is a good idea but we need some contributor discussion on it. Also, for a start, drop the changelog and metadata updates from this PR, as we do that separately when we cut releases. |
|
Should I drop the min-version for Noxy as well? That feels like something easy to forget, if so. |
Extracts the general logic from the se_teleport handling to a standalone framework usable for other mods.
Change depends on related pull request to add events to Noxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
This relies on a related pull request to add events to Noxy: NoxyNixie/Noxys_Multidirectional_Trains#9
This has not been rigorously tested, but initial tests seem promising. I do not have a complete understanding of how Cybersyn's internal logic works, and what additional considerations might be necessary.