WIP enable model caching #576
Open
+152
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the VSCode extension to use the new
CacheManagerfrom Malloy.Truncated cache works the same way it did before, except that for dependencies of the main file, it too will use the "real" cache.
We used to remove documents from the cache when the file was closed. Now we check if the file is used by any of the other files in the cache first. If A depends on B, closing B will not cause it to be removed from the cache, but then closing A will clear both. If you close A first, it will be removed from the cache, since nothing open depends on it.
Failing tests right now because this depends on changes that haven't landed in Malloy.