Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor currency representation and correct minor comment typos #72

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

shuhuiluo
Copy link
Collaborator

Restructured the handling of currencies in the system by consolidating all currency-related functionalities under the Currency trait. Eliminated the CurrencyTrait and the Currency enum, which were previously holding this responsibility across multiple code portions. Also corrected several minor errors in the comments and improved the comment descriptions across multiple files.

Don't merge until #71.

…typos

Restructured the handling of currencies in the system by consolidating all currency-related functionalities under the `Currency` trait. Eliminated the `CurrencyTrait` and the `Currency` enum, which were previously holding this responsibility across multiple code portions. Also corrected several minor errors in the comments and improved the comment descriptions across multiple files.
@shuhuiluo shuhuiluo requested a review from malik672 July 9, 2024 18:20
@shuhuiluo shuhuiluo self-assigned this Jul 9, 2024
@malik672 malik672 merged commit cff8aa8 into no_std Jul 9, 2024
2 checks passed
@shuhuiluo shuhuiluo deleted the currency branch July 10, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants