fix big-decimal issue #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuhuiluo
requested changes
Mar 17, 2024
Comment on lines
+221
to
+225
| let amount = CurrencyAmount::from_raw_amount(TOKEN0.clone(), 12345896).unwrap(); | ||
| assert_eq!( | ||
| amount.to_fixed(0, Rounding::RoundHalfUp).unwrap(), | ||
| "12345896" | ||
| ); |
There was a problem hiding this comment.
Don't change the test cases for the sake of passing tests. This is unacceptable.
https://github.com/Uniswap/sdk-core/blob/9a2fa2f53c5d9b8e71942f8100134f01f278bef8/src/entities/fractions/currencyAmount.test.ts#L68-L72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr aims to close issue #57
this is a significant change for those using the previous version of sdk-core