Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #50 #56

Merged
merged 7 commits into from
Mar 11, 2024
Merged

fix issue #50 #56

merged 7 commits into from
Mar 11, 2024

Conversation

malik672
Copy link
Owner

@malik672 malik672 commented Mar 9, 2024

this pull request aims to fix issue #50

@malik672 malik672 requested a review from shuhuiluo March 9, 2024 18:18
README.md Outdated Show resolved Hide resolved
fix

Co-authored-by: Shuhui Luo <[email protected]>
@malik672 malik672 requested a review from shuhuiluo March 10, 2024 09:52
@malik672 malik672 linked an issue Mar 10, 2024 that may be closed by this pull request
The example provided in the README.md was replaced with a more detailed and applicable example. It's now about creating a new Token instance for the DAI token on the Ethereum Mainnet using the `token!` macro. The contextual explanations for each code line have been expanded too for better understanding.
Copy link
Collaborator

@shuhuiluo shuhuiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge with squash.

@malik672 malik672 merged commit f72e4c2 into master Mar 11, 2024
2 checks passed
@malik672 malik672 deleted the upstream branch March 11, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give better examples in README
2 participants