Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redendant code + 0.9.0 #31

Merged
merged 5 commits into from
Jan 11, 2024
Merged

remove redendant code + 0.9.0 #31

merged 5 commits into from
Jan 11, 2024

Conversation

malik672
Copy link
Owner

remove redundant codes

@malik672 malik672 requested a review from shuhuiluo January 11, 2024 12:08
src/utils/sorted_insert.rs Outdated Show resolved Hide resolved
src/utils/sqrt.rs Outdated Show resolved Hide resolved
}

if items.len() > max_size {
return Err(Error::Incorrect("ITEMS_SIZE".to_owned()));
return Err(Error::Incorrect(
"items_size has to greater than max_size".to_string(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"items_size has to greater than max_size".to_string(),
"array length cannot exceed max_size".to_string(),

@malik672 malik672 force-pushed the add_recoverable_errors branch from e3abedf to a06d50f Compare January 11, 2024 12:32
@malik672 malik672 requested a review from shuhuiluo January 11, 2024 12:42
@malik672 malik672 merged commit 6854032 into master Jan 11, 2024
2 checks passed
@malik672 malik672 deleted the add_recoverable_errors branch January 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants