Add recoverable errors #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuhuiluo
requested changes
Jan 10, 2024
src/.DS_Store
Outdated
There was a problem hiding this comment.
You have to git rm --cached .DS_Store since it's already added to git indexing.
shuhuiluo
requested changes
Jan 11, 2024
| assert!(Fraction::new(5, 12) > Fraction::new(4, 12)); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_multiply() { | ||
| assert_eq!( | ||
| Fraction::new(1, 10) * Fraction::new(4, 12), | ||
| (Fraction::new(1, 10) * Fraction::new(4, 12)), |
There was a problem hiding this comment.
Adding redundant parenthesis only increases the cost to review.
src/entities/fractions/fraction.rs
Outdated
Comment on lines
348
to
349
| assert_eq!(f.clone().as_fraction(), f.clone()); | ||
| assert_ne!(&f.clone() as *const _, &f.clone().as_fraction() as *const _); |
There was a problem hiding this comment.
There is no need to make clones if the code was working as intended.
src/entities/fractions/percent.rs
Outdated
Comment on lines
25
to
27
| (self.as_fraction() * ONE_HUNDRED.clone()) | ||
| .to_significant(significant_digits, rounding) | ||
| .unwrap() |
There was a problem hiding this comment.
The base method returns Result<String, Error>. Why is it unwrapped here?
src/entities/fractions/percent.rs
Outdated
| } | ||
|
|
||
| /// Converts the Percent to a string with a fixed number of decimal places and rounding strategy | ||
| pub fn to_fixed(&self, decimal_places: u8, rounding: Rounding) -> String { | ||
| // Convert the Percent to a simple Fraction, multiply by 100, and then call to_fixed on the result | ||
| // Convert the Percent to a simple Fraction, multiply by 100, and then call to_fixed on the |
There was a problem hiding this comment.
Suggested change
| // Convert the Percent to a simple Fraction, multiply by 100, and then call to_fixed on the | |
| // Convert the Percent to a simple Fraction, multiply by 100, and then call to_fixed on the result |
Please don't accidentally delete comments.
| @@ -39,47 +41,47 @@ mod tests { | |||
| #[test] | |||
| fn test_add() { | |||
| assert_eq!( | |||
| Percent::new(1, 100) + Percent::new(2, 100), | |||
| (Percent::new(1, 100) + Percent::new(2, 100)), | |||
There was a problem hiding this comment.
These are just unnecessary diffs.
There was a problem hiding this comment.
is there a way clippy can discover this
src/entities/fractions/price.rs
Outdated
| return Err(Error::NotEqual("the comparison are not equal".to_owned())); | ||
| } | ||
|
|
||
| let fraction = (self.as_fraction() * other.as_fraction()).clone(); |
There was a problem hiding this comment.
A clone is unnecessary.
shuhuiluo
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #26
bump to 0.9.0
introduce recoverable errors