Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #26

Closed
shuhuiluo opened this issue Jan 5, 2024 · 6 comments
Closed

Improve error handling #26

shuhuiluo opened this issue Jan 5, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@shuhuiluo
Copy link
Collaborator

Ideally, errors should be recoverable. However, currently assert! and panic! are used instead.

@shuhuiluo shuhuiluo added the good first issue Good for newcomers label Jan 5, 2024
@malik672
Copy link
Owner

malik672 commented Jan 5, 2024

yep, how about custom errors or probably rust return type would be more viable

@shuhuiluo
Copy link
Collaborator Author

shuhuiluo commented Jan 5, 2024

yep, how about custom errors or probably rust return type would be more viable

An error enum derived from thiserror should do. It's just lots of refactoring.

@malik672
Copy link
Owner

malik672 commented Jan 5, 2024

would start soon

@malik672
Copy link
Owner

malik672 commented Jan 8, 2024

yep, how about custom errors or probably rust return type would be more viable

An error enum derived from thiserror should do. It's just lots of refactoring.

i've been doing a lot of refactoring, this would affect a lot implementation in v3

@shuhuiluo
Copy link
Collaborator Author

That's fine. Please release 0.8.0.

@malik672
Copy link
Owner

malik672 commented Jan 8, 2024

Will make a pr today, will do that after the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants