implement suggested fixes

malik672 · Jan 10, 2024 · f6724ac · f6724ac
1 parent dc5747c
commit f6724ac
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/src/entities/fractions/currency_amount.rs b/src/entities/fractions/currency_amount.rs
@@ -202,15 +202,15 @@ mod tests {
     #[should_panic(expected = "AMOUNT")]
     fn test_token_amount_exceeds_max_uint256() {
         let _w = CurrencyAmount::from_raw_amount(TOKEN18.clone(), MAX_UINT256.clone() + 1);
-        assert!(!_w.is_err(), "AMOUNT");
+        assert!(_w.is_ok(), "AMOUNT");
     }
 
     #[test]
     #[should_panic(expected = "AMOUNT")]
     fn test_token_amount_quotient_exceeds_max_uint256() {
         let numerator: BigInt = (MAX_UINT256.clone() + 1) * 2;
         let _w = CurrencyAmount::from_fractional_amount(TOKEN18.clone(), numerator, 2);
-        assert!(!_w.is_err(), "AMOUNT");
+        assert!(_w.is_ok(), "AMOUNT");
     }
 
     #[test]

diff --git a/src/entities/fractions/fraction.rs b/src/entities/fractions/fraction.rs
@@ -309,8 +309,8 @@ mod tests {
     #[test]
     fn test_less_than() {
         assert!(Fraction::new(1, 10).unwrap() < Fraction::new(4, 12).unwrap());
-        assert!(!(Fraction::new(1, 3).unwrap() < Fraction::new(4, 12).unwrap()));
-        assert!(!(Fraction::new(5, 12).unwrap() < Fraction::new(4, 12).unwrap()));
+        assert!(Fraction::new(1, 3).unwrap() >= Fraction::new(4, 12).unwrap());
+        assert!(Fraction::new(5, 12).unwrap() >= Fraction::new(4, 12).unwrap());
     }
 
     #[test]
@@ -322,8 +322,8 @@ mod tests {
 
     #[test]
     fn test_greater_than() {
-        assert!(!(Fraction::new(1, 10).unwrap() > Fraction::new(4, 12).unwrap()));
-        assert!(!(Fraction::new(1, 3).unwrap() > Fraction::new(4, 12).unwrap()));
+        assert!(Fraction::new(1, 10).unwrap() <= Fraction::new(4, 12).unwrap());
+        assert!(Fraction::new(1, 3).unwrap() <= Fraction::new(4, 12).unwrap());
         assert!(Fraction::new(5, 12).unwrap() > Fraction::new(4, 12).unwrap());
     }
 

diff --git a/src/entities/fractions/price.rs b/src/entities/fractions/price.rs
@@ -14,8 +14,6 @@ where
     pub base_currency: TBase,
     pub quote_currency: TQuote,
     pub scalar: Fraction,
-
-
 }
 
 impl<TBase, TQuote> Price<TBase, TQuote>