Speed up coded_bkw computation
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids symbolic computation at all cost for faster computation, especially since on line 62 there's a `sum` which computes the sum of (I believe) hundreds of expressions. Benchmarks on my laptop: Kyber512: 277.6s -> 12.25s Kyber1024: Long time -> 17.40s TFHE630: 539.4s -> 20.15s Look at that, 20x speed up!
bencrts
reviewed
Aug 22, 2023
|
I will fix #76 first, then this should follow. |
|
#76 has been shut down, so I have reverted those changes now, now this should be ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids symbolic computation at all cost for faster computation, especially since on line 62 there's a
sumwhich computes the sum of (I believe) hundreds of expressions. Benchmarks on my laptop:Kyber512: 277.6s -> 12.25s
Kyber1024: Long time -> 17.40s
TFHE630: 539.4s -> 20.15s
Look at that, 20x speed up! I'll also benchmark other places of the code and see what other fixes I have.
Depends on #76 for the changed import list. Hopefully it helps (beginning to?) resolve #74 and #75.