Fix MitM Babai e-admissability computation #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ludopulles
commented
Oct 16, 2024
ludopulles
commented
- The e^(-x^2) forgot to take the square in the exponent,
- there was a unnecessary change from stddev to standard width 'alphaq',
- negative values don't occur because the formula is right :),
- applying some scaling to (r_i, \sigma) such that \sigma = 1/\sqrt{2} makes formulas easier to parse.
|
I'm fixing the doctest failures on main. |
malb
reviewed
Oct 16, 2024
|
Okay, if you rebase on main, doctests should now run. |
|
Also: thank you! |
It was simply wrong. The e^(-x^2) forgot to take the square in the exponent, and the sigma was not really the standard deviation of the Gaussian sample (which they use in the proof).
|
Ta! |
|
Ooh. This is a nice catch @ludopulles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.