fix Issue 110 #112
Merged
fix Issue 110 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Made a small update but I think it's OK now |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1.
As in #110, the crash was caused by some missing
RR()swhich have been added below. After this, the code outlined in the issue runs but segfaults. The segfault happens for bothRC.BDGL16andRC.MATZOV, but for different reasons.Issue 2.
After fixing 1. Variants of
short_vectors()are crashing for different cost models and causing a segfault, this happens whencin the below code is huge (e.g.>2**large). Basically, we are calling e.g.ceil(2**large)and it just crashes. To avoid this, I picked an arbitrary value and set c toooin this case. The choice of the arbitrary value (2**1000) might need some discussion.I also added a blankline to
lwe_dual.pyfor readability.