update FilterBetweenDates

maks-oleksyuk · Dec 22, 2024 · cdcede9 · cdcede9
1 parent a5434e2
commit cdcede9
Show file tree

Hide file tree

Showing 2 changed files with 98 additions and 96 deletions.
diff --git a/app/Models/Traits/DynamicScopes/FilterBetweenDatesScope.php b/app/Models/Traits/DynamicScopes/FilterBetweenDatesScope.php
@@ -4,9 +4,9 @@
 
 namespace App\Models\Traits\DynamicScopes;
 
-use Carbon\Carbon;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Support\Carbon;
 
 /**
  * @template TModel of Model
@@ -20,11 +20,11 @@ trait FilterBetweenDatesScope
     public function scopeFilterBetweenDates(
         Builder $query,
         string $column,
-        string $start_date,
-        string $end_date,
+        Carbon $startDate,
+        Carbon $endDate,
     ): Builder {
         return $query
-            ->where($column, '>=', Carbon::parse($start_date)->startOfDay())
-            ->where($column, '<=', Carbon::parse($end_date)->endOfDay());
+            ->where($column, '>=', $startDate->startOfDay())
+            ->where($column, '<=', $endDate->endOfDay());
     }
 }